Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use context in the common pipeline #2447

Merged
merged 2 commits into from
Jul 12, 2023
Merged

feat: use context in the common pipeline #2447

merged 2 commits into from
Jul 12, 2023

Conversation

tty47
Copy link
Contributor

@tty47 tty47 commented Jul 10, 2023

hello team!

I've created a new version in the common pipeline, this one should fix the issues with the forks and we'll have the version output that we're currently missing when using the docker containers.

If this works, we could close the PR: #2421
I've tested on my end and seems to be working 🤞

PR where we've done the fix: celestiaorg/.github#65

Thanks in advance! 🚀

Jose Ramon Mañes

https://github.com/celestiaorg/devops/issues/370

Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
@tty47 tty47 requested review from sysrex, Bidon15 and smuu July 10, 2023 13:02
@tty47 tty47 self-assigned this Jul 10, 2023
@github-actions github-actions bot added the external Issues created by non node team members label Jul 10, 2023
@tty47 tty47 added kind:fix Attached to bug-fixing PRs ci:actions ci:docker Related to docker + dockerhub flow docker Pull requests that update Docker code and removed external Issues created by non node team members labels Jul 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Merging #2447 (f1ec8ad) into main (eaa5835) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2447      +/-   ##
==========================================
- Coverage   53.12%   53.02%   -0.11%     
==========================================
  Files         156      156              
  Lines        9907     9907              
==========================================
- Hits         5263     5253      -10     
- Misses       4188     4198      +10     
  Partials      456      456              

see 5 files with indirect coverage changes

Wondertan
Wondertan previously approved these changes Jul 10, 2023
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tty47
Copy link
Contributor Author

tty47 commented Jul 12, 2023

hello team!

I've updated the commit to use the latest version: v0.2.2

Thanks in advance!

Jose Ramon Mañes

@Wondertan Wondertan added this pull request to the merge queue Jul 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 12, 2023
@Wondertan Wondertan merged commit 579a060 into celestiaorg:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:actions ci:docker Related to docker + dockerhub flow docker Pull requests that update Docker code kind:fix Attached to bug-fixing PRs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants