-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use context in the common pipeline #2447
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
tty47
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
July 10, 2023 13:02
tty47
added
kind:fix
Attached to bug-fixing PRs
ci:actions
ci:docker
Related to docker + dockerhub flow
docker
Pull requests that update Docker code
and removed
external
Issues created by non node team members
labels
Jul 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #2447 +/- ##
==========================================
- Coverage 53.12% 53.02% -0.11%
==========================================
Files 156 156
Lines 9907 9907
==========================================
- Hits 5263 5253 -10
- Misses 4188 4198 +10
Partials 456 456 |
Wondertan
previously approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
hello team! I've updated the commit to use the latest version: v0.2.2 Thanks in advance! Jose Ramon Mañes |
Wondertan
approved these changes
Jul 12, 2023
rootulp
approved these changes
Jul 12, 2023
Bidon15
approved these changes
Jul 12, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci:actions
ci:docker
Related to docker + dockerhub flow
docker
Pull requests that update Docker code
kind:fix
Attached to bug-fixing PRs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello team!
I've created a new version in the common pipeline, this one should fix the issues with the forks and we'll have the version output that we're currently missing when using the docker containers.
If this works, we could close the PR: #2421
I've tested on my end and seems to be working 🤞
PR where we've done the fix: celestiaorg/.github#65
Thanks in advance! 🚀
Jose Ramon Mañes
https://github.com/celestiaorg/devops/issues/370