-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(swamp): befp testing #2584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
added
swamp
Related to Integration tests
kind:fix
Attached to bug-fixing PRs
labels
Aug 18, 2023
5 tasks
vgonkivs
requested review from
renaynay,
Wondertan,
distractedm1nd and
walldiss
as code owners
August 21, 2023 12:14
Codecov Report
@@ Coverage Diff @@
## main #2584 +/- ##
==========================================
- Coverage 51.13% 51.04% -0.10%
==========================================
Files 158 158
Lines 10576 10558 -18
==========================================
- Hits 5408 5389 -19
+ Misses 4696 4690 -6
- Partials 472 479 +7
|
distractedm1nd
previously approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really clean and straightforward
distractedm1nd
previously approved these changes
Aug 30, 2023
renaynay
previously approved these changes
Aug 30, 2023
distractedm1nd
previously approved these changes
Aug 30, 2023
Co-authored-by: Ryan <ryan@celestia.org>
evan-forbes
reviewed
Aug 31, 2023
distractedm1nd
approved these changes
Sep 4, 2023
walldiss
approved these changes
Sep 4, 2023
renaynay
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Reworked swamp test for the BEFP
Checklist