Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(swamp): befp testing #2584

Merged
merged 15 commits into from
Sep 4, 2023
Merged

tests(swamp): befp testing #2584

merged 15 commits into from
Sep 4, 2023

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Aug 18, 2023

Overview

Reworked swamp test for the BEFP

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added swamp Related to Integration tests kind:fix Attached to bug-fixing PRs labels Aug 18, 2023
@vgonkivs vgonkivs self-assigned this Aug 18, 2023
@vgonkivs vgonkivs marked this pull request as ready for review August 21, 2023 12:14
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Merging #2584 (a2111d5) into main (80d6dba) will decrease coverage by 0.10%.
The diff coverage is 23.07%.

@@            Coverage Diff             @@
##             main    #2584      +/-   ##
==========================================
- Coverage   51.13%   51.04%   -0.10%     
==========================================
  Files         158      158              
  Lines       10576    10558      -18     
==========================================
- Hits         5408     5389      -19     
+ Misses       4696     4690       -6     
- Partials      472      479       +7     
Files Changed Coverage Δ
header/headertest/testing.go 81.30% <ø> (+9.38%) ⬆️
nodebuilder/p2p/opts.go 0.00% <0.00%> (ø)
share/getters/ipld.go 62.22% <25.00%> (-1.74%) ⬇️
share/getters/cascade.go 69.13% <28.57%> (-4.20%) ⬇️

... and 8 files with indirect coverage changes

distractedm1nd
distractedm1nd previously approved these changes Aug 29, 2023
Copy link
Collaborator

@distractedm1nd distractedm1nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really clean and straightforward

distractedm1nd
distractedm1nd previously approved these changes Aug 30, 2023
renaynay
renaynay previously approved these changes Aug 30, 2023
nodebuilder/fraud/service.go Outdated Show resolved Hide resolved
share/getters/ipld.go Show resolved Hide resolved
@vgonkivs vgonkivs dismissed stale reviews from renaynay and distractedm1nd via 0eb06a3 August 30, 2023 15:22
distractedm1nd
distractedm1nd previously approved these changes Aug 30, 2023
share/getters/cascade.go Outdated Show resolved Hide resolved
Co-authored-by: Ryan <ryan@celestia.org>
nodebuilder/tests/fraud_test.go Show resolved Hide resolved
@vgonkivs vgonkivs enabled auto-merge (squash) September 4, 2023 12:08
@vgonkivs vgonkivs merged commit d75a743 into celestiaorg:main Sep 4, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Attached to bug-fixing PRs swamp Related to Integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants