Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: address namespace follow-ups from celestia-app v1.0.0-rc12 bump #2597

Merged
merged 3 commits into from
Aug 24, 2023
Merged

refactor: address namespace follow-ups from celestia-app v1.0.0-rc12 bump #2597

merged 3 commits into from
Aug 24, 2023

Conversation

rootulp
Copy link
Contributor

@rootulp rootulp commented Aug 22, 2023

Addresses two follow-ups from #2581
Closes #2561

@rootulp rootulp added the kind:refactor Attached to refactoring PRs label Aug 22, 2023
@rootulp rootulp self-assigned this Aug 22, 2023
@github-actions github-actions bot added the external Issues created by non node team members label Aug 22, 2023
@rootulp rootulp mentioned this pull request Aug 22, 2023
Merged
5 tasks
@rootulp rootulp marked this pull request as ready for review August 22, 2023 15:34
Wondertan
Wondertan reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

share/namespace.go Outdated Show resolved Hide resolved
@rootulp rootulp requested a review from Wondertan August 22, 2023 17:30
@rootulp rootulp enabled auto-merge (squash) August 23, 2023 19:07
@Wondertan Wondertan mentioned this pull request Aug 24, 2023
Closed
@rootulp rootulp merged commit 1205437 into celestiaorg:main Aug 24, 2023
12 of 14 checks passed
walldiss pushed a commit to walldiss/celestia-node that referenced this pull request Sep 22, 2023
@rootulp @walldiss
refactor: address namespace follow-ups from celestia-app v1.0.0-rc12 …
c6ee275 
…bump (celestiaorg#2597)

Addresses two follow-ups from
celestiaorg#2581
Closes celestiaorg#2561

(cherry picked from commit 1205437)
walldiss pushed a commit that referenced this pull request Sep 22, 2023
@rootulp @walldiss
refactor: address namespace follow-ups from celestia-app v1.0.0-rc12 …
1834813 
…bump (#2597)

Addresses two follow-ups from
#2581
Closes #2561

(cherry picked from commit 1205437)
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgonkivs vgonkivs vgonkivs approved these changes

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@rootulp rootulp

Labels
external Issues created by non node team members kind:refactor Attached to refactoring PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Account for secondary reserved namespace range
3 participants
@rootulp @Wondertan @vgonkivs