feat(discovery)!: discover peers by tag #2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramin
previously approved these changes
Sep 19, 2023
# Conflicts: # share/p2p/discovery/options.go
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2730 +/- ##
==========================================
- Coverage 51.73% 51.49% -0.24%
==========================================
Files 161 167 +6
Lines 10826 10758 -68
==========================================
- Hits 5601 5540 -61
- Misses 4731 4737 +6
+ Partials 494 481 -13
|
walldiss
force-pushed
the
discover-nodes-by-tag
branch
from
715fc25
to
fc879f7
Compare
walldiss
force-pushed
the
discover-nodes-by-tag
branch
from
79ec3ef
to
4a2bff3
Compare
renaynay
previously approved these changes
Sep 29, 2023
distractedm1nd
previously approved these changes
Oct 5, 2023
distractedm1nd
approved these changes
Oct 6, 2023
distractedm1nd
previously approved these changes
Oct 9, 2023
|
i didnt know i could double approve like that lol |
Wondertan
reviewed
Oct 9, 2023
- fix params validation - update test to use Start/Advertise api instead of passing special values params
Wondertan
approved these changes
Oct 9, 2023
renaynay
approved these changes
Oct 9, 2023
renaynay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to run multiple discovery subcomponents, where each can find new peers based on preset
tagand notify its subscribers. It could allow any sort of separate discovery subcomponents (versioned, pruned/archived, etc). Essentially it allows discovery to be abstracted away and act as single function component.Involves some minor refactoring here and there just to clean up things.
Resolves #2578