Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ci) matrix tests for different OS #2855

Merged
merged 10 commits into from
Oct 23, 2023
Merged

(ci) matrix tests for different OS #2855

merged 10 commits into from
Oct 23, 2023

Conversation

ramin
Copy link
Contributor

@ramin ramin commented Oct 18, 2023

Refs #1584

Lets run our test suite on multi configurations as they sometimes pass one not other (as reported by @vgonkivs)

  • Task: run tests on > 1 OS (previously ubuntu-latest only) now ubuntu-latest and macos-latest
  • currently ONLY for the unit tests (do we want to change this for all the tests?)
  • also makes a small unrequested tweak to make the execution in go-ci run AFTER the mod and lint checks, so it'll pause if those two fail and fail the entire pipeline faster. Save some wasted compute time, which will be at least x2 worse once we matrix these

example run: https://github.com/celestiaorg/celestia-node/actions/runs/6559066381/job/17813974060

…ails faster on smaller fixes. creates a matrix test for JUST unit for now refs #1584
@ramin ramin added the kind:ci CI related PRs label Oct 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Merging #2855 (5e329a3) into main (0b85448) will decrease coverage by 1.12%.
Report is 6 commits behind head on main.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main    #2855      +/-   ##
==========================================
- Coverage   51.16%   50.05%   -1.12%     
==========================================
  Files         167      167              
  Lines       10773    10775       +2     
==========================================
- Hits         5512     5393     -119     
- Misses       4764     4891     +127     
+ Partials      497      491       -6     
Files Coverage Δ
core/listener.go 53.50% <100.00%> (ø)
nodebuilder/p2p/addrs.go 75.00% <100.00%> (+1.19%) ⬆️
blob/service.go 4.26% <0.00%> (-65.86%) ⬇️

... and 8 files with indirect coverage changes

@ramin ramin marked this pull request as ready for review October 19, 2023 09:23
@ramin ramin changed the title [DRAFT] matrix tests for different OS (ci) matrix tests for different OS Oct 19, 2023
renaynay
renaynay previously approved these changes Oct 19, 2023
@ramin ramin enabled auto-merge (squash) October 19, 2023 09:53
vgonkivs
vgonkivs previously approved these changes Oct 19, 2023
walldiss
walldiss previously approved these changes Oct 19, 2023
Wondertan
Wondertan previously approved these changes Oct 19, 2023
@ramin ramin dismissed stale reviews from Wondertan, walldiss, vgonkivs, and renaynay via bdd898a October 19, 2023 22:12
renaynay
renaynay previously approved these changes Oct 20, 2023
vgonkivs
vgonkivs previously approved these changes Oct 20, 2023
Wondertan
Wondertan previously approved these changes Oct 20, 2023
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTack

@ramin ramin dismissed stale reviews from Wondertan and vgonkivs via abaf384 October 20, 2023 14:21
Wondertan
Wondertan previously approved these changes Oct 23, 2023
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

distractedm1nd
distractedm1nd previously approved these changes Oct 23, 2023
Copy link
Collaborator

@distractedm1nd distractedm1nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ramin ramin dismissed stale reviews from Wondertan and distractedm1nd via 5e329a3 October 23, 2023 12:14
@ramin ramin merged commit 1a5d63c into main Oct 23, 2023
15 of 18 checks passed
@ramin ramin deleted the ci/ramin/matrix-tests branch October 23, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:ci CI related PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants