Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signed binaries for goreleaser #2869

Merged
merged 1 commit into from
Oct 26, 2023
Merged

signed binaries for goreleaser #2869

merged 1 commit into from
Oct 26, 2023

Conversation

ramin
Copy link
Contributor

@ramin ramin commented Oct 23, 2023

mimics the signed binaries by goreleaser as implemented in celestia-app so node can also generate signed binaries

@MSevey confirmed that we have an org level secret for GPG_SIGNING_KEY and GPG_PASSPHRASE so should require no repo setup

implementation for app: celestiaorg/celestia-app@934fded

Will follow up with some work to ensure this workflow actually gets triggered (currently the steps before do not pass and generate binaries)

closes: #2679

@ramin ramin requested a review from MSevey October 23, 2023 15:42
@ramin ramin added the kind:ci CI related PRs label Oct 23, 2023
@renaynay renaynay added the kind:misc Attached to miscellaneous PRs label Oct 24, 2023
@MSevey
Copy link
Member

MSevey commented Oct 24, 2023

Changes lgtm. Actions unfortunately still don't really have a great way to test beside live testing.

For this one, I'd recommend making a new clean fork of the repo so that you can merge this change into that fork. Then update the CI workflow to bypass the tests so that the release is triggered so that you can then verify that the binaries and release are generated and then you can download and verify the binary as well.

@ramin
Copy link
Contributor Author

ramin commented Oct 26, 2023

@MSevey replicated and got this setup working and signing on one of our test tools https://github.com/ramin/waypoint/actions/runs/6645867234/job/18058097433#step:5:54, really only thing i can't test is that our GPG secrets are available and correct, so we'll have to do it live. Will get this entire pipeline running next so we can see it generate some artifacts

@ramin ramin merged commit 7d54545 into main Oct 26, 2023
18 of 21 checks passed
@ramin ramin deleted the ci/ramin/signed-binaries branch October 26, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:ci CI related PRs kind:misc Attached to miscellaneous PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Signed Binaries
4 participants