refactor(nodebuilder/share/cmd)!: Take block height instead of ExtendedHeader as argument for share cmds
#2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bao1029p
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
Wondertan
previously approved these changes
Oct 24, 2023
renaynay
changed the title
ExtendedHeader as argument for share cmds
added 2 commits
October 26, 2023 16:49
|
hey @Wondertan, i added both usage of block hash and height in |
Wondertan
requested changes
Oct 26, 2023
Wondertan
reviewed
Oct 26, 2023
vgonkivs
requested changes
Oct 27, 2023
Wondertan
approved these changes
Oct 27, 2023
yes i've tested it and everything work great |
vgonkivs
approved these changes
Oct 30, 2023
Wondertan
added
kind:break!
renaynay
approved these changes
Oct 30, 2023
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 Celestia Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace extended headers with block height as an argument in shares cmd
Issues close
Close #2848
Changes made
extended headeras an argument with block height innodebuilder/share/cmd/share.go.block heightfor