fix(share/byzantine): fix proof collection #2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
added
area:shares
vgonkivs
requested review from
renaynay,
Wondertan,
distractedm1nd and
walldiss
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2957 +/- ##
==========================================
+ Coverage 50.88% 51.01% +0.12%
==========================================
Files 168 168
Lines 11021 11035 +14
==========================================
+ Hits 5608 5629 +21
+ Misses 4915 4903 -12
- Partials 498 503 +5 ☔ View full report in Codecov by Sentry. |
Wondertan
previously approved these changes
Nov 27, 2023
walldiss
reviewed
Nov 30, 2023
No, it's not possible to have n < len(dah.RowRoots)/2. Rsmt2d guarantees to return at least half of the row/col. iirc, "failed to solve data square" will be returned for the case that you mentioned. |
walldiss
approved these changes
Dec 7, 2023
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Jan 15, 2024
This PR fixes an issue in the proof collection method. Previously, we were sending `len(dah.RowRoots)/2` requests in order to get proofs but there is a use case when the process can get stuck for a particular share(out-of-order case). The new approach sends n requests, where n is the number of non-empty shares received from rsmt2d library, and then waits until `len(dah.RowRoots)/2` will be received. I've also improved error handling as previously we were panicking in case any error appeared. The new approach will rely only on `context.DeadlineExceeded ` which basically means that for some reason we can't get proofs, so the data is not available. --------- Co-authored-by: ramin <raminkeene@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the proof collection method. Previously, we were sending
len(dah.RowRoots)/2requests in order to get proofs but there is a use case when the process can get stuck for a particular share(out-of-order case). The new approach sends n requests, where n is the number of non-empty shares received from rsmt2d library, and then waits untillen(dah.RowRoots)/2will be received.I've also improved error handling as previously we were panicking in case any error appeared. The new approach will rely only on
context.DeadlineExceededwhich basically means that for some reason we can't get proofs, so the data is not available.