Revert "fix(modp2p): temporary disable quic (#2837)" #2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 17619db.
Wondertan
requested review from
renaynay,
vgonkivs,
distractedm1nd and
walldiss
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2963 +/- ##
==========================================
- Coverage 50.98% 50.73% -0.25%
==========================================
Files 168 168
Lines 10937 10921 -16
==========================================
- Hits 5576 5541 -35
- Misses 4865 4886 +21
+ Partials 496 494 -2 ☔ View full report in Codecov by Sentry. |
walldiss
approved these changes
Nov 27, 2023
vgonkivs
approved these changes
Dec 13, 2023
|
I thought this was merged already 😱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts disabled quic. We weren't able to reproduce the issue since we first observed it, as well as quic released changes to address this. Even if the issue is there, I think it's more or less safe as we always have TCP as fallback