Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd): explicitly set a string representation of the error #2997

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Dec 8, 2023

json.MarshalIndent cut the result in case of error is received in PrintOutput, so the string representation was empty.

celestia state balance-for-address celestia1kanc76z0xet2kgq5fl3pj59axy56htk367trer --url=https://full.consensus.mocha-4.celestia-mocha.com --node.store=~/.celestia-light-mocha-4
{ "result": "RPC client error: sendRequest failed: Post \"https://full.consensus.mocha-4.celestia-mocha.com\": dial tcp 151.115.12.131:443: connect: connection refused" }

@vgonkivs vgonkivs added the kind:fix Attached to bug-fixing PRs label Dec 8, 2023
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@vgonkivs vgonkivs self-assigned this Dec 8, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (b7b6350) 50.88% compared to head (f74111d) 50.92%.
Report is 1 commits behind head on main.

Files Patch % Lines
das/daser.go 63.63% 3 Missing and 1 partial ⚠️
das/options.go 0.00% 4 Missing ⚠️
nodebuilder/das/constructors.go 0.00% 2 Missing ⚠️
cmd/util.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2997      +/-   ##
==========================================
+ Coverage   50.88%   50.92%   +0.03%     
==========================================
  Files         168      168              
  Lines       11021    11038      +17     
==========================================
+ Hits         5608     5621      +13     
+ Misses       4915     4914       -1     
- Partials      498      503       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgonkivs vgonkivs merged commit b709b4e into celestiaorg:main Dec 8, 2023
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants