feat(share/p2p/peer-manager): limit amount of stored pools in peer-manager #3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
ramin
as code owners
walldiss
changed the title
Wondertan
reviewed
Dec 13, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3005 +/- ##
==========================================
- Coverage 50.94% 50.68% -0.26%
==========================================
Files 176 176
Lines 11190 11172 -18
==========================================
- Hits 5701 5663 -38
- Misses 4986 5012 +26
+ Partials 503 497 -6 ☔ View full report in Codecov by Sentry. |
walldiss
commented
Dec 13, 2023
walldiss
changed the title
walldiss
changed the title
Wondertan
reviewed
Dec 14, 2023
|
Yes, memory leak is solved. |
… peer-manager-memory-leak # Conflicts: # share/p2p/peers/manager.go
Wondertan
approved these changes
Dec 15, 2023
vgonkivs
approved these changes
Dec 15, 2023
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Jan 15, 2024
…nager (celestiaorg#3005) This PR introduces `amountOfStoredPools` param to Peer manager, that will limit amount of stored pools. Defautlt value is 10 pools. Peer manager will try to keep `amountOfStoredPools` amount of pools only for recent headers. Older blocks don't need to be routed by manual pools and could be routed to any full node, as those are expected to have the block by that time. This will lower memory footprint of peer manager as well as resolve memory leaking issues. Resolves celestiaorg#1781
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
amountOfStoredPoolsparam to Peer manager, that will limit amount of stored pools. Defautlt value is 10 pools. Peer manager will try to keepamountOfStoredPoolsamount of pools only for recent headers. Older blocks don't need to be routed by manual pools and could be routed to any full node, as those are expected to have the block by that time.This will lower memory footprint of peer manager as well as resolve memory leaking issues.
Resolves #1781