service/header: Refactor HeaderService to separate distinct components into clearer sub-components
#317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
reviewed
Dec 27, 2021
Wondertan
reviewed
Dec 27, 2021
renaynay
force-pushed
the
header-service-lifecycle-manager
branch
from
995a7ea
to
b75078d
Compare
renaynay
commented
Dec 28, 2021
renaynay
commented
Dec 28, 2021
renaynay
commented
Dec 28, 2021
renaynay
commented
Dec 28, 2021
renaynay
commented
Dec 28, 2021
renaynay
changed the title
HeaderService refactoring in progressHeaderService to only manage its sub-services' lifecycles
renaynay
force-pushed
the
header-service-lifecycle-manager
branch
from
e0ad250
to
c59f5cb
Compare
renaynay
changed the title
HeaderService to only manage its sub-services' lifecyclesHeaderService to separate distinct components into clearer sub-components
renaynay
force-pushed
the
header-service-lifecycle-manager
branch
from
2ad37dc
to
e2b712b
Compare
Wondertan
reviewed
Jan 3, 2022
Wondertan
reviewed
Jan 3, 2022
Wondertan
reviewed
Jan 3, 2022
Wondertan
reviewed
Jan 3, 2022
Wondertan
previously approved these changes
Jan 3, 2022
liamsi
reviewed
Jan 5, 2022
liamsi
reviewed
Jan 5, 2022
liamsi
reviewed
Jan 5, 2022
liamsi
previously approved these changes
Jan 5, 2022
This was referenced Jan 5, 2022
renaynay
force-pushed
the
header-service-lifecycle-manager
branch
from
10ac82b
to
475729e
Compare
Wondertan
approved these changes
Jan 5, 2022
liamsi
approved these changes
Jan 5, 2022
Bidon15
pushed a commit
to Bidon15/celestia-node
that referenced
this pull request
Jan 11, 2022
…nts into clearer sub-components (celestiaorg#317)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
HeaderServicein order to make it agnostic to the details of its sub-services.HeaderService's no longer has any function and only contains pointers to its subcomponents for later use once we scope out the RPC component. All ingredients necessary to construct its sub-services are created during node construction. Sub-service lifecycle management is also delegated to the DI application.P2PExchangestart the server-side component (which is necessary for all nodes), but not need it for its exchange component when in bridge mode, the server-side component is split out into a separate lifecycle which is present for every node type as all nodes can serve headers, but not all nodes request headers from the same method (p2p vs. directly from core).This PR is quite large but its necessary moving forward as
HeaderServiceis the largest and most complicated component of celestia-node, and many other services are dependent on it, so keeping it clean and its sub-services nicely self-contained is crucial.Another thing to mention is that this PR includes commits from #277, rendering that PR unnecessary on its own, and should also precede #303.
Resolves #287