node: Wrap datastore with mutex to prevent data race #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Wondertan <hlibwondertan@gmail.com>
Wondertan
approved these changes
Jan 4, 2022
Bidon15
changed the title
renaynay
approved these changes
Jan 4, 2022
Bidon15
added a commit
to Bidon15/celestia-node
that referenced
this pull request
Jan 11, 2022
* node: update vanilla datastore with Mutex one Co-authored-by: Wondertan <hlibwondertan@gmail.com> * update Changelog Co-authored-by: Wondertan <hlibwondertan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With current datastore, we bump into the race condition when the datastore is being both read and written to. Changing to mutex wrapped datastore has eliminated the data race error findings.
This case is heavily blocking proper initialisation of node and can cause flakiness in test execution.
Found during work on #262
Co-authored with @Wondertan