Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly fetch Validators from Core and two more fixes #328

Merged
merged 7 commits into from
Jan 7, 2022

Conversation

Wondertan
Copy link
Member

Includes critical fix for #319 and two minor findings. Commit names are descriptive enough so check those

Closes #319

@Wondertan Wondertan self-assigned this Jan 6, 2022
service/header/header.go Show resolved Hide resolved
service/header/header.go Show resolved Hide resolved
service/header/header.go Show resolved Hide resolved
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits but thanks for this pr

CHANGELOG-PENDING.md Outdated Show resolved Hide resolved
core/fetcher.go Outdated Show resolved Hide resolved
core/fetcher.go Outdated Show resolved Hide resolved
core/fetcher.go Outdated Show resolved Hide resolved
core/fetcher.go Outdated Show resolved Hide resolved
service/header/header.go Show resolved Hide resolved
@Wondertan Wondertan changed the title Bunch of fixes Properly fetch Validators from Core and two more fixes Jan 6, 2022
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼 Nice work!

Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one question

core/fetcher.go Show resolved Hide resolved
@Wondertan Wondertan merged commit 6503125 into main Jan 7, 2022
@Wondertan Wondertan deleted the hlib/fix-fetcher-pagination branch January 7, 2022 14:11
Wondertan added a commit that referenced this pull request Jan 7, 2022
@Wondertan Wondertan restored the hlib/fix-fetcher-pagination branch January 7, 2022 14:40
@liamsi
Copy link
Member

liamsi commented Jan 7, 2022

I thought brnaches get auto-deleted:
image

@liamsi liamsi deleted the hlib/fix-fetcher-pagination branch January 7, 2022 14:59
Bidon15 pushed a commit to Bidon15/celestia-node that referenced this pull request Jan 11, 2022
Bidon15 pushed a commit to Bidon15/celestia-node that referenced this pull request Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Full node doesn't sync after celestia-appd is offline for a few days: validator set mismatch
3 participants