Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/share: Implement FullAvailability #333

Merged
merged 4 commits into from
Jan 14, 2022
Merged

service/share: Implement FullAvailability #333

merged 4 commits into from
Jan 14, 2022

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Jan 9, 2022 •
edited
Loading

Resolves #179 and #23

@renaynay renaynay marked this pull request as ready for review January 9, 2022 16:25
Wondertan
Wondertan reviewed Jan 10, 2022
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first pAss looks good.

node/components.go Outdated Show resolved Hide resolved
service/share/full_availability.go Show resolved Hide resolved
service/share/share.go Outdated Show resolved Hide resolved
service/share/testing.go Show resolved Hide resolved
@renaynay
full avail
feb984e 
update get shares algo and remove full avail from bridge components
@renaynay renaynay requested a review from liamsi January 12, 2022 13:34
liamsi
liamsi previously approved these changes Jan 12, 2022
View reviewed changes
Wondertan
Wondertan previously approved these changes Jan 13, 2022
View reviewed changes
node/components.go Outdated Show resolved Hide resolved
service/share/full_availability.go Show resolved Hide resolved
@renaynay renaynay dismissed stale reviews from Wondertan and liamsi via fb2a4c4 January 13, 2022 13:10
Wondertan
Wondertan previously approved these changes Jan 13, 2022
View reviewed changes
liamsi
liamsi reviewed Jan 13, 2022
View reviewed changes
node/components.go Outdated Show resolved Hide resolved
Wondertan
Wondertan reviewed Jan 13, 2022
View reviewed changes
node/components.go Outdated Show resolved Hide resolved
@renaynay @Wondertan
comment
aaa0578 
Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
liamsi
liamsi approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renaynay renaynay merged commit ffe8522 into celestiaorg:main Jan 14, 2022
@renaynay renaynay deleted the full-availability branch January 14, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@liamsi liamsi liamsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

share: Full Availability
3 participants
@renaynay @liamsi @Wondertan