Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(params): add bootstrappers #399

Merged
merged 2 commits into from
Jan 26, 2022
Merged

feat(params): add bootstrappers #399

merged 2 commits into from
Jan 26, 2022

Conversation

Wondertan
Copy link
Member

Just added a list of boostrappers

@Wondertan Wondertan self-assigned this Jan 26, 2022
@Wondertan
Copy link
Member Author

I tested manually by connecting to those addresses.

liamsi
liamsi approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if these was in a config file instead of hardcoded but that is OK.

@renaynay
Copy link
Member

@liamsi geth also hardcodes them, this is normal.

@liamsi
Copy link
Member

liamsi commented Jan 26, 2022

geth also hardcodes them, this is normal.

per network / testnet?

@Wondertan
Copy link
Member Author

Wondertan commented Jan 26, 2022 •
edited
Loading

Moreover, everyone hardcodes them besides tendermint networks and they should do follow this as well.

@Wondertan Wondertan merged commit b62fc1d into main Jan 26, 2022
@Wondertan Wondertan deleted the hlib/add-bootstrappers branch January 26, 2022 17:17
@renaynay renaynay mentioned this pull request Apr 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaynay renaynay renaynay approved these changes

@liamsi liamsi liamsi approved these changes

Assignees

@Wondertan Wondertan

Labels
None yet
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wondertan @renaynay @liamsi