block: create Fetcher interface
#59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
force-pushed
the
block-service-fetcher
branch
4 times, most recently
from
dbcccac
to
bfa5c45
Compare
This was
linked to
issues
Sep 14, 2021
renaynay
changed the title
Fetcher interfaceFetcher interface
Wondertan
requested changes
Sep 15, 2021
liamsi
reviewed
Sep 16, 2021
liamsi
reviewed
Sep 16, 2021
liamsi
reviewed
Sep 16, 2021
liamsi
reviewed
Sep 16, 2021
liamsi
reviewed
Sep 16, 2021
liamsi
reviewed
Sep 16, 2021
There was a problem hiding this comment.
This PR looks good to me for the most part. I don't understand why that channel should be guarded by a mutex? (cc @Wondertan) Otherwise left some minor suggestions.
Wondertan
requested changes
Sep 16, 2021
|
re #59 (comment) @Wondertan -- because this channel is specifically to listen for |
Wondertan
requested changes
Sep 16, 2021
renaynay
force-pushed
the
block-service-fetcher
branch
from
b9140d7
to
f81276f
Compare
Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
renaynay
force-pushed
the
block-service-fetcher
branch
from
f81276f
to
b809d03
Compare
department
liamsi
approved these changes
Sep 17, 2021
There was a problem hiding this comment.
Great work @renaynay and thanks for the thorough reviews @Wondertan 👏🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a block
Fetcherinterface that will encompass the behaviour necessary for theBlockServiceto get new blocks either directly from a Core node or from the Celestia network.It also adds an implementation of
Fetcherfor the CoreClientTODO
BlockServicetoFullnodeRelated to #25 and #26