-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libs/fslock: a simple utility to lock directories #71
Conversation
d7eeff8
to
680536a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It makes me a bit anxious about how few test cases are there. Speaking of which can we add a badge with test-coverage to this repo like in the others (cc @Bidon15).
Would like to merge it today pls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nits but otherwise i'm okay with it. Will see how it will be used later when CLI created.
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
9b30c5a
to
7bc44c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Context
Over the weekend in my spare time, I was playing around syscalls and wanted to implement something. The idea fell to do something useful to our current tasks and so I decided to make a locking library, as we need to lock our Repo from simultaneous usage. I am aware there are existing libraries solving that, but this one is especially minimal.
Filling