-
Notifications
You must be signed in to change notification settings - Fork 421
docs: mocha v6 upgrade height #2254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rootulp
commented
Sep 29, 2025
Summary of ChangesHello @rootulp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the accuracy and presentation of the network upgrade documentation. It primarily updates the specific details for the upcoming Mocha v6 network upgrade, providing crucial information like the exact date and block height. Additionally, it includes minor stylistic improvements to the tables within the document, ensuring a consistent and clear presentation of upgrade information for all network participants. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the documentation with the Mocha v6 upgrade height and date. It also applies formatting changes to all Markdown tables in the file. The content update is accurate. I have provided one suggestion regarding best practices for future pull requests, recommending the separation of content updates from widespread formatting changes to improve clarity and ease of review.
| Network | Chain ID | Date and time | Upgrade height | Delay period | | ||
|--------------|------------|-------------------------|-------------------------------------------------------------------|--------------| | ||
| Arabica | arabica-11 | 2025/09/09 06:08:11 UTC | [8105605](https://arabica.celenium.io/block/8105605) | 1 day | | ||
| Mocha | mocha-4 | 2025/10/03 01:25:02 UTC | [8236886](https://www.mintscan.io/celestia-testnet/block/8236886) | 2 days | | ||
| Mainnet Beta | celestia | TBD | TBD | 7 days | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update to the Mocha upgrade details looks correct, thank you. A suggestion for future pull requests: this PR mixes a content update with file-wide formatting changes (e.g., in this table and others on lines 45, 69, 92, and 106). It's generally a good practice to separate these concerns into different pull requests. This makes reviews more focused and the commit history cleaner.
the repo and your linter must be slightly different 👀 |