enable the user to choose a concrete tree implementation #8 #9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| package rsmt2d | ||
|
|
||
| import ( | ||
| "crypto/sha256" | ||
| "fmt" | ||
|
|
||
| "github.com/lazyledger/merkletree" | ||
| ) | ||
|
|
||
| // TreeConstructorFn creates a fresh Tree instance to be used as the Merkle inside of rsmt2d. | ||
| type TreeConstructorFn = func() Tree | ||
|
|
||
| type Tree interface { | ||
| Push(data []byte) | ||
| // TODO(ismail): is this general enough? | ||
| Prove(idx int) (merkleRoot []byte, proofSet [][]byte, proofIndex uint64, numLeaves uint64) | ||
| Root() []byte | ||
| } | ||
|
Comment on lines
+13
to
+18
There was a problem hiding this comment. Please don't merge yet. Trying to distill a minimal interface. This one is basically nebolouslabs' API (and these are the methods used). |
||
|
|
||
| var _ Tree = &DefaultTree{} | ||
|
There was a problem hiding this comment. How would developers use their own tree implementation for the library? Create a struct that implements Tree, then supply a function that creates a new tree? There was a problem hiding this comment.
Yes, exactly. |
||
|
|
||
| type DefaultTree struct { | ||
| *merkletree.Tree | ||
| leaves [][]byte | ||
| root []byte | ||
| } | ||
|
|
||
| func NewDefaultTree() Tree { | ||
| return &DefaultTree{ | ||
| Tree: merkletree.New(sha256.New()), | ||
| leaves: make([][]byte, 0, 128), | ||
| } | ||
| } | ||
|
|
||
| func (d *DefaultTree) Push(data []byte) { | ||
| d.leaves = append(d.leaves, data) | ||
| } | ||
|
|
||
| func (d *DefaultTree) Prove(idx int) (merkleRoot []byte, proofSet [][]byte, proofIndex uint64, numLeaves uint64) { | ||
| if err := d.Tree.SetIndex(uint64(idx)); err != nil { | ||
| panic(fmt.Sprintf("don't call prove on a already used tree: %v", err)) | ||
| } | ||
| for _, l := range d.leaves { | ||
| d.Tree.Push(l) | ||
| } | ||
| return d.Tree.Prove() | ||
| } | ||
|
|
||
| func (d *DefaultTree) Root() []byte { | ||
| if d.root == nil { | ||
| for _, l := range d.leaves { | ||
| d.Tree.Push(l) | ||
| } | ||
| d.root = d.Tree.Root() | ||
| } | ||
| return d.root | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compare: https://github.com/lazyledger/nmt/blob/1a5d9124ad10e40d0d743d7695e1983992089a2f/nmt.go#L110
https://github.com/lazyledger/nmt/blob/1a5d9124ad10e40d0d743d7695e1983992089a2f/proof.go#L19