This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
refactor: Make examples executable #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, the examples cannot be executed without manually linking NPM modules to the correct locations, i.e. the `node_modules/` dir in project root. This makes it really hard to just try out an example as a user or as a developer working on opencensus-node. This PR moves the example to a *private* module under `packages/`. This means that lerna will automatically initialise the necessary symlinks for developers working on this project. Users on the other hand, could just run `npm install` and manually execute the examples.
kjin
pushed a commit
to kjin/opencensus-node
that referenced
this pull request
Aug 24, 2018
Right now, the examples cannot be executed without manually linking NPM modules to the correct locations, i.e. the `node_modules/` dir in project root. This makes it really hard to just try out an example as a user or as a developer working on opencensus-node. This PR moves the example to a *private* module under `packages/`. This means that lerna will automatically initialise the necessary symlinks for developers working on this project. Users on the other hand, could just run `npm install` and manually execute the examples.
kjin
pushed a commit
to kjin/opencensus-node
that referenced
this pull request
Aug 24, 2018
Right now, the examples cannot be executed without manually linking NPM modules to the correct locations, i.e. the `node_modules/` dir in project root. This makes it really hard to just try out an example as a user or as a developer working on opencensus-node. This PR moves the example to a *private* module under `packages/`. This means that lerna will automatically initialise the necessary symlinks for developers working on this project. Users on the other hand, could just run `npm install` and manually execute the examples.
kjin
pushed a commit
to kjin/opencensus-node
that referenced
this pull request
Aug 24, 2018
Right now, the examples cannot be executed without manually linking NPM modules to the correct locations, i.e. the `node_modules/` dir in project root. This makes it really hard to just try out an example as a user or as a developer working on opencensus-node. This PR moves the example to a *private* module under `packages/`. This means that lerna will automatically initialise the necessary symlinks for developers working on this project. Users on the other hand, could just run `npm install` and manually execute the examples.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the examples cannot be executed without manually linking NPM
modules to the correct locations, i.e. the
node_modules/dir inproject root. This makes it really hard to just try out an example as a
user or as a developer working on opencensus-node.
This PR moves the example to a private module under
packages/. Thismeans that lerna will automatically initialise the necessary symlinks
for developers working on this project. Users on the other hand, could
just run
npm installand manually execute the examples.