Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutually exclusive conditions on deployment with dmcrypt dedicated journal #1054

Closed
9seconds opened this issue Oct 26, 2016 · 1 comment
Closed

Comments

@9seconds
Copy link
Contributor

I've been trying to deploy ceph cluster with dedicated dmcrypted journals and met following:

To prepare OSDs with dmcrypt, i need to set both raw_multi_journal and dmcrypt_dedicated_journal to true:
https://github.com/ceph/ceph-ansible/blob/master/roles/ceph-osd/tasks/scenarios/dmcrypt-dedicated-journal.yml#L25-L27

But at the same time, this is invalid settings here: https://github.com/ceph/ceph-ansible/blob/master/roles/ceph-common/tasks/checks/check_mandatory_vars.yml#L96

I've tried to remove mutually exclusive or (dmcrypt_dedicated_journal and raw_multi_journal) and deployment is OK, but I am not quite sure if it won't break anything else.

@andrewschoen
Copy link
Contributor

Thanks for the report. I think the fix here is to remove this line: https://github.com/ceph/ceph-ansible/blob/master/roles/ceph-osd/tasks/scenarios/dmcrypt-dedicated-journal.yml#L25

The check in check_mandatory_vars is correct because you really can't use dmcrypt_dedicated_journal and raw_multi_journal at the same time.

andrewschoen added a commit that referenced this issue Oct 28, 2016
Fixes: #1054

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Resolves: issue#1054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants