firewall: configure firewalld if it's already installed on the host (… #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eph#2192). Signed-off-by: Eduard Egorov <eduard.egorov@icl-services.com>
eduardegorov
force-pushed
the
configure_firewalld_if_exists
branch
from
005b9c5
to
49d7d94
Compare
leseb
requested changes
Nov 20, 2017
There was a problem hiding this comment.
Overall, this looks good, thanks! However, it'd be nice if this could happen automatically. If we detect firewalld is up and running then we add ceph rules. Can you try that? Basically, users shouldn't have to enable configure_firewall. Thanks!
Also, I think you're missing some of the daemons too (MDS, rbd-mirror etc).
eduardegorov
force-pushed
the
configure_firewalld_if_exists
branch
2 times, most recently
from
136f7ef
to
710084b
Compare
|
@leseb , pushed as an additional commit(see above):
|
eduardegorov
force-pushed
the
configure_firewalld_if_exists
branch
from
710084b
to
ca20845
Compare
…rewall' variable used for conditional execution. Include the task only on rpm-based systems. Signed-off-by: Eduard Egorov <eduard.egorov@icl-services.com>
eduardegorov
force-pushed
the
configure_firewalld_if_exists
branch
from
ca20845
to
a29e355
Compare
leseb
approved these changes
Dec 12, 2017
guits
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#2192).
Signed-off-by: Eduard Egorov eduard.egorov@icl-services.com