ceph.conf: fail if interface does not have any IP #2263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
force-pushed
the
interface-not-empty
branch
5 times, most recently
from
f7db8e8
to
98bced8
Compare
We want to fail if the interface provided for either mon/rgw does not have any IP. Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
interface-not-empty
branch
from
98bced8
to
262c5c6
Compare
|
@leseb this feature could be addressed by the upcoming 'host var / pre check' validation module I think. |
|
I'm not sure, it's hard to tell. The use case here is: a user provides a network interface for a monitor and that interface doesn't have any IP. I'm not sure if the upcoming module will solve that in the first iteration. I'll leave this one open just so we don't forget about it. |
|
if the upcoming module can access |
|
@andrewschoen any thoughts on this? |
|
Closing this in favor of #2915 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to fail if the interface provided for either mon/rgw does not
have any IP.
Signed-off-by: Sébastien Han seb@redhat.com