mgr: always free allocated MgrPyModule #14507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use unique_ptr to manage the lifecycle of MgrPyModule and ServeThread, it's easier and safer. without this chance, we don't free allocated MgrPyModule if it fails to load(). Fixes: http://tracker.ceph.com/issues/19590 Signed-off-by: Kefu Chai <kchai@redhat.com>
liewegas
approved these changes
Apr 13, 2017
jcsp
approved these changes
Apr 15, 2017
Abhishekvrshny
pushed a commit
to Abhishekvrshny/ceph
that referenced
this pull request
Jul 13, 2017
Description: If the user/admin removes a bucket using --force/--purge-objects options with s3cmd/radosgw-admin respectively, the user stats will continue to reflect the deleted objects for quota purposes, and there seems to be no way to reset them. User stats need to be sync'ed prior to bucket removal. Solution: Sync user stats before removing a bucket. Fixes: ceph#14507 Signed-off-by: Edward Yang <eyang@us.fujitsu.com> (cherry picked from commit 0650799) Conflicts: src/rgw/rgw_op.cc reordering the check seqence and replace some op_ret to ret Backport Change: We remove the `tenant` parameter because this feature is not introduced on hammer version. The rgw multi-tenant feature is introduced on pr#6784 (ceph#6784) This feature is supported from v10.0.2 and later version. (cherry picked from commit c722d00) Conflicts: src/rgw/rgw_op.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use unique_ptr to manage the lifecycle of MgrPyModule and ServeThread,
it's easier and safer. without this chance, we don't free allocated
MgrPyModule if it fails to load().
Fixes: http://tracker.ceph.com/issues/19590
Signed-off-by: Kefu Chai kchai@redhat.com