Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: increase maximum number of trash entries listable #785

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

phlogistonjohn
Copy link
Collaborator

Work around an issue reported that due to a large number of items in the rbd trash the function fails rather than listing the items as desired. This short term fix simply increases the limit rather than doing anything long term.

Fixes: #779

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview

@phlogistonjohn
Copy link
Collaborator Author

FYI: @aarononeal

@phlogistonjohn phlogistonjohn added the no-API This PR does not include any changes to the public API of a go-ceph package label Nov 15, 2022
@phlogistonjohn
Copy link
Collaborator Author

@Mergifyio rebase

Work around an issue reported that due to a large number of items in the
rbd trash the function fails rather than listing the items as desired.
This short term fix simply increases the limit rather than doing
anything long term.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
@mergify
Copy link

mergify bot commented Nov 16, 2022

rebase

✅ Branch has been successfully rebased

@phlogistonjohn
Copy link
Collaborator Author

@ansiwen @anoopcs9 please don't let the dev-branch CI failures discourage you from reviewing the PR. These failures are not blocking failures.

Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@mergify mergify bot merged commit b956ad1 into ceph:master Nov 17, 2022
@phlogistonjohn phlogistonjohn deleted the jjm-issue779 branch November 28, 2022 18:57
@Madhu-1
Copy link

Madhu-1 commented May 4, 2023

@phlogistonjohn Do we have any plan to fix this problem, even this limit can also be hit at scale.

@phlogistonjohn
Copy link
Collaborator Author

@phlogistonjohn Do we have any plan to fix this problem, even this limit can also be hit at scale.

OK, I didn't know that this was still an issue. We can probably come up with an alternate (more complex but more scalable) API for this. Let's track it in a new github issue though, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to list images in trash blocks PV cleanup
3 participants