QoL: Fix tox.ini syntax and other minor things #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix tox.ini syntax Modern tox versions require the expected environment variables to be listed one by one on separate lines in tox.ini - Add `venv` to list of ignored names for git This is a common name for a local Python virtual environment. Less typing than `virtualenv` - Add `tox` to requirements.txt Installing `tox` via `pip` has the advantage of including it in the virtual environment, thus avoiding trouble on operating systems shipping by default with python3.6 or older. It's also nice that `pip install -r requirements.txt` is now sufficient to set up the testing environment, after initializing the virtual environment with a moder-enough python version. Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
cbodley
approved these changes
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern tox versions require the expected environment variables to be listed one by one on separate lines in tox.ini
venvto list of ignored names for gitThis is a common name for a local Python virtual environment. Less typing than
virtualenvtoxto requirements.txtInstalling
toxviapiphas the advantage of including it in the virtual environment, thus avoiding trouble on operating systems shipping by default with python3.6 or older. It's also nice thatpip install -r requirements.txtis now sufficient to set up the testing environment, after initializing the virtual environment with a moder-enough python version.