Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Start up Node Metrics publishing after the Model becomes available locally #3268

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

stbrody
Copy link
Contributor

@stbrody stbrody commented Jul 24, 2024

New approach instead of #3265.

Now we start a background job that waits forever for the NodeMetrics model to be synced (using exponential backoff, maxing out at checking once per minute). If the model never becomes available, that job will keep checking for the Model once per minute, and will log an error once every 5 minutes. If the model ever becomes available, however, it will start up the NodeMetrics publishing subsystem at that point and the background task stops.

@stbrody stbrody self-assigned this Jul 24, 2024
Copy link

linear bot commented Jul 24, 2024

@stbrody stbrody force-pushed the wait-for-model-aes-232-new-approach branch from f5eaffd to fcb5062 Compare July 29, 2024 18:25
Copy link
Contributor

@gvelez17 gvelez17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, yes we should NOT have to registerInterest in the network wide metrics if possible, in order to publish to them!

@stbrody stbrody merged commit 679b8f8 into develop Jul 30, 2024
7 checks passed
@stbrody stbrody deleted the wait-for-model-aes-232-new-approach branch July 30, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants