ui: file upload, fileTree, forms: RepoField, TagsInput #1424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamfilos
changed the title
pamfilos
force-pushed
the
ui-files-async
branch
from
e317e98 to
64fcf33
Compare
pamfilos
changed the title
|
Lint errors
|
papadopan
reviewed
Feb 4, 2020
| <FileManager key="filesManager" files={this.props.files} />, | ||
| // <FileList key="filesList" files={this.props.files} />, | ||
| <Box key="filesList" pad="small"> | ||
| <Box key="filesList" style={{ paddingLeft: "3px", paddingRight: "10px" }}> |
There was a problem hiding this comment.
maybe something like this instead
pad={{left:"small", right:"medium"}} in order to keep the grommet values
papadopan
reviewed
Feb 4, 2020
| render() { | ||
| return <TreeNode data={this.state.data} />; | ||
| return ( | ||
| <Box style={{ marginLeft: "5px" }}> |
There was a problem hiding this comment.
Should we instead margin={{left:'small'}}
papadopan
reviewed
Feb 4, 2020
pamfilos
force-pushed
the
ui-files-async
branch
from
64fcf33 to
7a2a7c2
Compare
Signed-off-by: Pamfilos Fokianos <pamfilosf@gmail.com>
Signed-off-by: Pamfilos Fokianos <pamfilosf@gmail.com>
Signed-off-by: Pamfilos Fokianos <pamfilosf@gmail.com>
pamfilos
force-pushed
the
ui-files-async
branch
from
7a2a7c2 to
fc4061f
Compare
Signed-off-by: Pamfilos Fokianos <pamfilosf@gmail.com>
pamfilos
force-pushed
the
ui-files-async
branch
from
fc4061f to
de2f0c1
Compare
annatrz
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.