cli: add docker image upload #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrisovic
force-pushed
the
docker
branch
2 times, most recently
from
bd52536 to
a736f8a
Compare
annatrz
requested changes
Feb 15, 2018
cap_client/cap_api.py
Outdated
| check_call(["docker", "save", "-o", "{}.tar".format(img_name), img_name]) | ||
| self.upload(pid=pid, filepath=img_name, output_filename=img_name) | ||
| check_call(["rm", "{}.tar".format(img_name)]) | ||
| except CalledProcessError: |
cap_client/cli/cli.py
Outdated
| try: | ||
| response = ctx.obj.cap_api.docker_push(pid=pid, img_name=img_name) | ||
| click.echo(json.dumps(response, indent=4)) | ||
| except Exception as ex: |
There was a problem hiding this comment.
here first catch with StatusCodeException, check other cli methods
atrisovic
force-pushed
the
docker
branch
13 times, most recently
from
12fc33a to
1f6fead
Compare
atrisovic
changed the title
atrisovic
force-pushed
the
docker
branch
2 times, most recently
from
8e840b5 to
28526ba
Compare
atrisovic
force-pushed
the
docker
branch
3 times, most recently
from
52bbbb0 to
736984f
Compare
Signed-off-by: Ana Trisovic <ana.trisovic@gmail.com>
ioannistsanaktsidis
approved these changes
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ana Trisovic ana.trisovic@gmail.com