-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API versions to v1 #78
base: main
Are you sure you want to change the base?
Conversation
This PR actually removes the beta API and graduates to v1 if I understand correctly? Have we had any discussion about whether this is ready to be graduated? Should we not be serving both APIs alongside each other for a while to allow folks to upgrade existing resources? Should there be upgrade notes for users etc? |
I do think that the project is becoming ready to reach v1- I don't think the API is going to significantly change going forward. I also don't think it is worth serving both APIs. Both v1beta1 and v1 will be the same, and would be simpler to have users upgrade to v1 straight away. Would be a simple case of uninstalling, updating the I do think that we should publish another release for this PR (and v1) though. |
/hold |
Having thought about this for a bit, I agree- as long as they delete the resources and uninstall the CRDs before upgrade it should work and I guess there is no harm in temporarily not having those issuers in cluster as the shortest lived cert is anyway 1 hour. |
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Branched from #75
PR updates all API versions from
v1beta1
tov1
./assign @irbekrm