-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the meetings and slack information to a separate page #859
base: master
Are you sure you want to change the base?
Move the meetings and slack information to a separate page #859
Conversation
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: 84f4358 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/622a2623bb888e00080eb35f 😎 Browse the preview: https://deploy-preview-859--cert-manager-website.netlify.app |
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Richard, I think moving this info to a separate section makes a lot of sense
I have added one request for change and two optional suggestions.
type: "docs" | ||
--- | ||
|
||
## Meetings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this new page needs to be added to the index, so it appears in the list of topics on the main contributing page
We have 2 regular repeating meetings: | ||
|
||
* daily stand-up meetings [on Google Meet](https://meet.google.com/eum-fyvt-xpa) at [10:30 London time](http://www.thetimezoneconverter.com/?t=10:30&tz=Europe/London) every weekday | ||
* bi-weekly developer meetings [on Google Meet](https://meet.google.com/abp-bwhk-wxc) at [17:00 London time](http://www.thetimezoneconverter.com/?t=17:00&tz=Europe/London) (for dates, check calendar invites or [meeting notes](https://docs.google.com/document/d/1Tc5t6ylY9dhXAan1OjOoldeaoys1Yh4Ir710ATfBa5U)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: note the fact that these meetings are recorded and provide a link to our YT page
@@ -1,6 +1,6 @@ | |||
--- | |||
title: "Meet the maintainers" | |||
linkTitle: "talk-to-us" | |||
title: "Contact the maintainers" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: I find that this title does not really reflect the content well, from the name I would expect this to contain our email address, these communication channels are imo for different type of involvement, i.e asking a question that could be answered by other community members on cert-manager Slack. I also cannot think of a perfect name, but would suggest 'Community'
@wallrj: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by review: got a suggestion around redirects 🚗
## Meetings | ||
|
||
All cert-manager meetings are open for everyone to join. | ||
|
||
To get invites you can subscribe to [our mailing list](https://groups.google.com/forum/#!forum/cert-manager-dev). | ||
|
||
We have 2 regular repeating meetings: | ||
|
||
* daily stand-up meetings [on Google Meet](https://meet.google.com/eum-fyvt-xpa) at [10:30 London time](http://www.thetimezoneconverter.com/?t=10:30&tz=Europe/London) every weekday | ||
* bi-weekly developer meetings [on Google Meet](https://meet.google.com/abp-bwhk-wxc) at [17:00 London time](http://www.thetimezoneconverter.com/?t=17:00&tz=Europe/London) (for dates, check calendar invites or [meeting notes](https://docs.google.com/document/d/1Tc5t6ylY9dhXAan1OjOoldeaoys1Yh4Ir710ATfBa5U)) | ||
|
||
## Slack | ||
|
||
We have two cert-manager channels on [the Kubernetes Slack](https://slack.k8s.io) which we use to communicate: | ||
|
||
* `cert-manager`: a general channel for all users of cert-manager; use this one for any usage related questions. | ||
* `cert-manager-dev`: a channel for collaboration between cert-manager contributors and maintainers; please only use this for code related questions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: (just seen this PR by chance) I feel like we have a lot of places where we directly link to these links:
https://cert-manager.io/docs/contributing/#meetings
https://cert-manager.io/docs/contributing/#slack
E.g. we used them in the slides for our recent TAG Security presentation, and I've used them in slack a lot before.
I think we'd massively benefit from adding redirects from those links to the new page, so that users with the old links end up in the right place. Is that possible?
as well as how to compile, run and test cert-manager and all it's components. | ||
as well as how to compile, run and test cert-manager and all its components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: Can't believe I didn't see this before! 👀 Good spot!
We've been reviewing the contributing guide and agreed that having the meetings and slack information as the main content of the contributing guide is distracting.
New contributors first concern is how to check out and build the code.