-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RPZ file output bot #1962
Add RPZ file output bot #1962
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1962 +/- ##
===========================================
+ Coverage 75.74% 75.96% +0.21%
===========================================
Files 414 434 +20
Lines 22169 23283 +1114
Branches 2944 3111 +167
===========================================
+ Hits 16793 17686 +893
- Misses 4697 4879 +182
- Partials 679 718 +39
|
Hi @mariuskarotkis thank you for contributing so much new stuff =) Looks all very good on the first glance. Unfortunately I fear we won't have time for the reviews this week, so we'll need to keep you waiting a few days. But be assured that we don't ignore you :) |
You can be sure that we haven't forgot your PRs, and we're currently working hard. Unfortunately we need to hold a deadline for IntelMQ 3.0 and as we're short-staffed currently, we've had to postpone some activities, like reviewing the PRs. If I won't have time for a review before 3.0, we'll put your additions into 3.1 of course. Sorry for these circumstances :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I am primarily missing is documentation for the bot which explains what it does, how it does it, how it can be configured and what can be achieved with it (linking to external sources is perfectly fine).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Apart from the minor change it looks good overall
I'll apply the change myself after merging, then we can finally conclude this as well. Sorry for the long waiting - with volatile priorities, it's not always easy to have enough time for the reviews. But I think that the current state is much better than what we had before.
class RpzFileOutputBot(OutputBot): | ||
_file = None | ||
format_filename: bool = False | ||
__Bot_is_multithreadable = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__Bot_is_multithreadable = False | |
_is_multithreadable = False |
That was recently fixed/changed in 5c91a8c you could not have foreseen this
Add new bot: RPZ file output
Example output file: