Add new bot: domain valid

[mariuskarotkis]

Add new bot: domain valid

[ghost]

Hi @mariuskarotkis and thanks for the contribution

On the first glance, this looks very similar to the domain suffix expert, which uses the PSL. Is there a specific reason you did create a new specialized bot instead of utilizing the domain-suffix expert and filtering on the source.domain_suffix field?

[mariuskarotkis]

Hi @wagner-certat
This expert allows only valid domains.

I didn't know about the expert domain-suffix.
I'll try it, thanks.

[codecov-commenter]

Codecov Report

Merging #1966 (b2acff3) into develop (7eaf71e) will decrease coverage by 0.07%.
The diff coverage is 60.65%.

@@             Coverage Diff             @@
##           develop    #1966      +/-   ##
===========================================
- Coverage    75.98%   75.90%   -0.08%     
===========================================
  Files          423      425       +2     
  Lines        22812    22934     +122     
  Branches      3040     3058      +18     
===========================================
+ Hits         17334    17409      +75     
- Misses        4772     4817      +45     
- Partials       706      708       +2     

Impacted Files	Coverage Δ
intelmq/bots/experts/domain_valid/expert.py	42.85% <42.85%> (ø)
...lmq/tests/bots/experts/domain_valid/test_expert.py	100.00% <100.00%> (ø)
intelmq/bots/experts/ripe/expert.py	77.55% <0.00%> (+1.02%)	⬆️

[ghost]

I did a review of the code and I have a few suggestions/required changes.

[ghost]

Please add a file intelmq/tests/bots/experts/domain_valid/tlds-alpha-by-domain.txt.license with the following content:

SPDX-FileCopyrightText: 2021 Marius Karotkis <marius.karotkis@gmail.com>
SPDX-License-Identifier: AGPL-3.0-or-later

With these proposals incorporated, the bot runs fine and the checks should succeed. Also tested locally.

If you add the suggestions, I'll finally merge the PR after a long odyssey :)