-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new feeds to Dataplane parser #2102
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2102 +/- ##
===========================================
- Coverage 76.04% 76.04% -0.01%
===========================================
Files 434 434
Lines 23218 23222 +4
Branches 3104 3108 +4
===========================================
+ Hits 17657 17660 +3
- Misses 4852 4853 +1
Partials 709 709
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would appreciate entries in intelmq/etc/feeds.yaml
:)
Apart from that I found nothing to complain about ;)
b455cfa
to
fbc8276
Compare
I added the documentation, plus a helper function called |
Thank you! |
This PR adds support for all of the currently available Dataplane feeds, i.e dns{rd{,any},version}, proto41, smtp{data,greet}, telnetlogin and vncrfb, in addition to the ones currently supported.
Some general code changes to the parser were also made.
Tests for the newly supported feeds were also added, along with a rework of the tests.