Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature meta data #206

Merged
merged 11 commits into from
Oct 18, 2016
Merged

Feature meta data #206

merged 11 commits into from
Oct 18, 2016

Conversation

stefanv
Copy link
Contributor

@stefanv stefanv commented Oct 15, 2016

No description provided.

bnaul and others added 5 commits October 14, 2016 16:29
@bnaul
Add feature contribution guidelines to CONTRIBUTING.md
75700c7
@acrellin
All features call cesium functions
e0c4673
@acrellin
Write feature tables in doc
21659f7
@stefanv
Merge remote-tracking branches 'acrellin/docs', 'bnaul/master' and 'a…
baf87ac 
…crellin/feature_functions' into feature_meta_data
@stefanv
Refactor feature meta-data
014409f 
- Category lists are now stored as a single dictionary
- Features are all entered into a single graph
@acrellin
Copy link
Member

Is this a synthesis of all of our open pull requests? ☺️

@acrellin
Copy link
Member

Nice! Like the feature category stuff. I'll push on the tags functionality Monday and Tuesday.

@stefanv
Copy link
Contributor Author

stefanv commented Oct 15, 2016

Yes, I blended them all together to see how they worked :) Turns out, pretty well! I then made sure the docs get generated correctly, etc. I'm still not quite happy with the documentation for the features---it doesn't quite feel right. Perhaps you have some ideas on how to improve that.

@acrellin
Copy link
Member

I'll need more than "doesn't quite feel right" to know how to refactor it
to your liking.

On Friday, October 14, 2016, Stefan van der Walt notifications@github.com
wrote:

Yes, I blended them all together to see how they worked :) Turns out,
pretty well! I then made sure the docs get generated correctly, etc. I'm
still not quite happy with the documentation for the features---it doesn't
quite feel right. Perhaps you have some ideas on how to improve that.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#206 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AG5TTe1R1kshwf4pjBYVT8m3zYxqFRveks5q0HfEgaJpZM4KXlTr
.

@bnaul bnaul mentioned this pull request Oct 17, 2016
Closed
@acrellin acrellin mentioned this pull request Oct 17, 2016
Closed
@stefanv stefanv changed the title WIP: Feature meta data Feature meta data Oct 17, 2016
@acrellin acrellin mentioned this pull request Oct 17, 2016
Closed
@acrellin
Copy link
Member

Where are we at on this one?

@stefanv
Copy link
Contributor Author

stefanv commented Oct 18, 2016

We're good to go, I think.

@acrellin
Copy link
Member

Ok, feel free to merge.

@stefanv stefanv merged commit f957c42 into cesium-ml:master Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanv @acrellin @bnaul