-
Notifications
You must be signed in to change notification settings - Fork 7
build: upgrade to Phoenix LiveView 1.0 #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Remove
plugin(({addVariant}) => addVariant('phx-no-feedback', ['&.phx-no-feedback', '.phx-no-feedback &']))
fromtailwind.config.js
based on this. -
phx-feedback-for
was also deprecated on1.0.0-rc.0
-
I think this is something that can be added
config :phoenix_live_view, debug_heex_annotations: true
, which provides special HTML comments that wrap around rendered components to help you identify where markup in your HTML document is rendered within your function component tree.
This update is from 0.20.0 (2023-09-22) -
Also update the CI dependencies.
-
Flop also needs to change from, based on Flop Changelog 0.22
@derive {
Flop.Schema,
default_limit: 7,
filterable: [:accepted],
sortable: [:collaborator_name, :inserted_at, :updated_at],
default_order: %{
order_by: [:inserted_at],
order_directions: [:desc]
},
join_fields: [
collaborator_name: [binding: :user, field: :name, path: [:user, :name]]
]
}
to:
@derive {
Flop.Schema,
default_limit: 7,
filterable: [:accepted],
sortable: [:collaborator_name, :inserted_at, :updated_at],
default_order: %{
order_by: [:inserted_at],
order_directions: [:desc]
},
adapter_opts: [
join_fields: [
collaborator_name: [binding: :user, field: :name, path: [:user, :name]]
]
]
}
I have decided to use a shim provided by Chris McCord to keep using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!
Description