Skip to content

Conversation

joaodiaslobo
Copy link
Member

Description

  • Now using Phoenix LiveView 1.0 🚀
  • Also updates Elixir to 1.17.2 and Erlang 27.0

@joaodiaslobo joaodiaslobo self-assigned this Feb 28, 2025
Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove plugin(({addVariant}) => addVariant('phx-no-feedback', ['&.phx-no-feedback', '.phx-no-feedback &'])) from tailwind.config.js based on this.

  2. phx-feedback-for was also deprecated on 1.0.0-rc.0

  3. I think this is something that can be added config :phoenix_live_view, debug_heex_annotations: true, which provides special HTML comments that wrap around rendered components to help you identify where markup in your HTML document is rendered within your function component tree.
    This update is from 0.20.0 (2023-09-22)

  4. Also update the CI dependencies.

  5. Flop also needs to change from, based on Flop Changelog 0.22

  @derive {
    Flop.Schema,
    default_limit: 7,
    filterable: [:accepted],
    sortable: [:collaborator_name, :inserted_at, :updated_at],
    default_order: %{
      order_by: [:inserted_at],
      order_directions: [:desc]
    },
    join_fields: [
      collaborator_name: [binding: :user, field: :name, path: [:user, :name]]
    ]
  }

to:

 @derive {
  Flop.Schema,
  default_limit: 7,
  filterable: [:accepted],
  sortable: [:collaborator_name, :inserted_at, :updated_at],
  default_order: %{
    order_by: [:inserted_at],
    order_directions: [:desc]
  },
  adapter_opts: [
      join_fields: [
        collaborator_name: [binding: :user, field: :name, path: [:user, :name]]
      ]
  ]
} 

@joaodiaslobo
Copy link
Member Author

I have decided to use a shim provided by Chris McCord to keep using phx-feedback-for, because our form styles rely too heavily on it, and it isn't a refactor we should be doing right now.

Copy link
Member

@nunom27 nunom27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

@joaodiaslobo joaodiaslobo merged commit 737378e into develop Mar 5, 2025
2 checks passed
@joaodiaslobo joaodiaslobo deleted the jl/upgrade-dependencies branch March 5, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants