Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preface fixes #45

Merged
merged 1 commit into from
Nov 24, 2015
Merged

Preface fixes #45

merged 1 commit into from
Nov 24, 2015

Conversation

rhattersley
Copy link
Member

Tidy-up syntax and clarify revision history status.

Closes #14.

@rhattersley
Copy link
Member Author

@JonathanGregory, @davidhassell, @rsignell-usgs, @marqh - if we can merge this PR and the other recent PRs I've raised we will have addressed all known issues ... exciting times!

@marqh
Copy link
Member

marqh commented Nov 24, 2015

exciting times!

exciting indeed

this one is fine, it now matches the current 1.6 doc

marqh added a commit that referenced this pull request Nov 24, 2015
@marqh marqh merged commit f52d15d into cf-convention:master Nov 24, 2015
@rhattersley rhattersley deleted the fixup-preface branch November 25, 2015 08:48
@rhattersley
Copy link
Member Author

Thanks @marqh

@rhattersley rhattersley modified the milestone: 1.6 Nov 25, 2015
@JonathanGregory
Copy link
Contributor

It looks lovely - thanks very much and well done. Is there a way to make a PDF of it, so I can print it out nicely and sit down with it and the existing PDF to compare them side-by-side?

I noticed one thing in the preface: the link is out of date. http://www-pcmdi.llnl.gov/cf/ should be replaced with http://cfconventions.org/.

Best wishes

Jonathan

@rhattersley
Copy link
Member Author

I noticed one thing in the preface: the link is out of date

Yes - I spotted that but left it alone to respect the existing DocBook version. If you're happy for it to be updated then I can apply the quick fix. Or you might like to click on the pencil icon for pr01.adoc (with the tool-tip text "Fork this project and edit the file") which will let you modify the text and create a new pull request all in the browser.

@rhattersley rhattersley mentioned this pull request Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants