Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical updates to front page "version line" #487

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

larsbarring
Copy link
Contributor

@larsbarring larsbarring commented Nov 22, 2023

See issue #XXX for discussion of these changes.
This PR, which has no associated issue, is intended to do two things:

  • Activate the html link to https://cfconventions.org in the "version line" (below author list) of the html document.
  • Change the spaces in the text related to the same html link to non-breaking spaces so that a possible line break in the pdf version does not chop up the text (this should have been done already in PR#464.

Release checklist

  • Authors updated in cf-conventions.adoc?
  • Next version in cf-conventions.adoc up to date? Versioning inspired by SemVer.
  • history.adoc up to date?
  • Conformance document up-to-date?

For maintainers

After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then, main always is a draft for the next version.

@larsbarring larsbarring force-pushed the test_sed branch 3 times, most recently from 507c574 to 2dbdce3 Compare November 22, 2023 18:00
@larsbarring larsbarring added this to the 1.11 milestone Nov 24, 2023
@larsbarring
Copy link
Contributor Author

This is a purely technical and formatting PR. It builds on PR #475 and needs to be updated as soon as that one is merged. Because it does not aftect the content in any way, it should be possible to merge this one as soon as it has been established that it does what is intended.

@larsbarring larsbarring force-pushed the test_sed branch 3 times, most recently from d76468d to 0efa7d2 Compare November 27, 2023 13:53
@larsbarring larsbarring changed the title DRAFT: use sed to inject html code to make link live Technical updates to front page "version line" Nov 27, 2023
@larsbarring
Copy link
Contributor Author

The result of these changes can be checked by downloading the zipped documents that resultsw from the gh action. These are available from this link. Essentially, here are screen captures of the changes:

Current version html:
image

New version html:
image

Current version pdf:
image

New version pdf:
image

@larsbarring
Copy link
Contributor Author

@davidhassell could you have a final look and merge if nothing comes up.

@davidhassell
Copy link
Contributor

Hi Lars, is the file generated in https://github.com/cf-convention/cf-conventions/actions/runs/7005988899 the most up to date? It has some rogue <, >:
image
When I run the sed locally, I don't see them.

@larsbarring
Copy link
Contributor Author

larsbarring commented Nov 27, 2023

OK, the < > are now removed. And I have just checked the produced artefacts and they look good.

@larsbarring
Copy link
Contributor Author

And now using sed back-reference correctly. Artefacts still looks ok.

@larsbarring larsbarring force-pushed the test_sed branch 2 times, most recently from 9f3bfaa to 9642c98 Compare November 28, 2023 15:45
@davidhassell davidhassell merged commit dfdeab9 into cf-convention:main Dec 1, 2023
4 checks passed
@larsbarring larsbarring deleted the test_sed branch December 1, 2023 16:54
@larsbarring larsbarring mentioned this pull request Dec 4, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants