Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sadie Bartholomew as author #489

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

davidhassell
Copy link
Contributor

See issue #XXX for discussion of these changes.
New authorship partially omitted from #469 - rectifying that here.

Release checklist

  • Authors updated in cf-conventions.adoc?
  • Next version in cf-conventions.adoc up to date? Versioning inspired by SemVer.
  • history.adoc up to date?
  • Conformance document up-to-date?

For maintainers

After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then, main always is a draft for the next version.

@davidhassell davidhassell added this to the 1.11 milestone Nov 27, 2023
@larsbarring larsbarring merged commit 86067f3 into cf-convention:main Nov 27, 2023
4 checks passed
@sadielbartholomew
Copy link
Member

sadielbartholomew commented Nov 27, 2023

Ah, sorry. I didn't realise we had to update two places to get our name included and I only added it in the later listing in a653314.

On that note, since both Chris Barker and I made the mistake of not adding our names in both places which seems very easy-to-do IMO (as I gather from the email thread on this), it seems like it would be useful and wise to indicate briefly in the PULL_REQUEST_TEMPLATE.md that two additions are required, for example I suggest something like:

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 269c93e..98b7438 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,7 +1,7 @@
 See issue #XXX for discussion of these changes.
 
 # Release checklist
-- [ ] Authors updated in `cf-conventions.adoc`?
+- [ ] Authors updated in `cf-conventions.adoc` (in two places: on line 3 and under `.Additional Authors` in `About the authors`)?
 - [ ] Next version in `cf-conventions.adoc` up to date? Versioning inspired by [SemVer](https://semver.org).
 - [ ] `history.adoc` up to date?
 - [ ] Conformance document up-to-date?

(I am assuming the 'Original Authors' will remain static given its nature.)

@sadielbartholomew
Copy link
Member

sadielbartholomew commented Nov 27, 2023

Oh and, since I have now noticed this and it bugs me somewhat, to make the grammar consistent on the final two points I would also like to do:

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 269c93e..4070de7 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -3,7 +3,7 @@ See issue #XXX for discussion of these changes.
 # Release checklist
 - [ ] Authors updated in `cf-conventions.adoc`?
 - [ ] Next version in `cf-conventions.adoc` up to date? Versioning inspired by [SemVer](https://semver.org).
-- [ ] `history.adoc` up to date?
+- [ ] `history.adoc` up-to-date?
 - [ ] Conformance document up-to-date?
 
 # For maintainers

(Putting a PR up to request these minor tweaks. Too minor for an Issue I think, but the PR can always be closed if the changes are deemed not suitable.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants