Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build gh-action to use Makefile and embed images into HTML document #522

Merged
merged 23 commits into from
Oct 20, 2024

Conversation

cofinoa
Copy link
Contributor

@cofinoa cofinoa commented Jun 5, 2024

See issue #523 for discussion of these changes.

Release checklist

  • Authors updated in cf-conventions.adoc? Add in two places: on line 3 and under .Additional Authors in About the authors.
  • [NA] Next version in cf-conventions.adoc up to date? Versioning inspired by SemVer.
  • history.adoc up to date?
  • [NA ] Conformance document up to date?

For maintainers

After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then, main always is a draft for the next version.

Copy link
Contributor

@larsbarring larsbarring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my pretty limited knowledge this looks fine.

@cofinoa
Copy link
Contributor Author

cofinoa commented Sep 20, 2024

@JonathanGregory and @davidhassell

I know that we are in the process to publish 1.12, but I think this PR could contribute to improve the "user" experience to build the conventions and conformance documents.

@JonathanGregory JonathanGregory linked an issue Sep 20, 2024 that may be closed by this pull request
@JonathanGregory JonathanGregory added this to the 1.12 milestone Sep 20, 2024
@cofinoa cofinoa changed the title Embed images into HTML document Embed images into HTML document and more Sep 24, 2024
@cofinoa cofinoa changed the title Embed images into HTML document and more Embed images into HTML document and add Makefile Oct 2, 2024
@cofinoa
Copy link
Contributor Author

cofinoa commented Oct 2, 2024

@davidhassell and @JonathanGregory

I have added and updated the Makefile to build the conformance and conventions documents.

The Makefile allows building just one document and format (or both), but only in your local computer.

I have updated the README.md accordingly, please review and update.

I'm modifying the GH action to use the Makefile in the build process.

@cofinoa cofinoa changed the title Embed images into HTML document and add Makefile Refactor build gh-action to use Makefile and embed images into HTML document Oct 2, 2024
@cofinoa cofinoa added enhancement Proposals to add new capabilities, improve existing ones in the conventions, improve style or format GitHub Improvement to how we use GitHub for this repository labels Oct 2, 2024
@JonathanGregory JonathanGregory merged commit 1216649 into cf-convention:main Oct 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Proposals to add new capabilities, improve existing ones in the conventions, improve style or format GitHub Improvement to how we use GitHub for this repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed images into HTML document
3 participants