Catch Elasticsearch errors #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amymok
requested review from
rosskarchner,
sephcoster,
AdamZarger and
JeffreyMFarley
complaint_search/views.py
Outdated
| res = { | ||
| "error": 'Elasticsearch error: ' + e.error | ||
| } | ||
| return Response(res, status=status_code) |
There was a problem hiding this comment.
This block is essentially duplicated three times. May want to rewrite as a wrapper function? Or a decorated method?
|
@JeffreyMFarley That was a great suggestion, I moved that block to a decorator now. |
JeffreyMFarley
approved these changes
Jul 7, 2017
AdamZarger
pushed a commit
to AdamZarger/ccdb5-api
that referenced
this pull request
Sep 22, 2017
Reimplement UrlBarSynch in redux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes code to catch any elasticsearch errors from the es_interface, and handle them gracefully with 400 errors. This should prevent any unnecessary 500 error for the user.
Additions: