Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input errors if attempting to borrow more than total cost of attendance #267

Merged
merged 10 commits into from
Aug 8, 2016

Conversation

marteki
Copy link
Member

@marteki marteki commented Aug 8, 2016

This fixes input errors if attempting to borrow more than total cost of attendance, and consolidates how our input elements are updated.

It also updates our NPM packages.

Additions

  • Add gradPlusOverCost to available borrowing errors

Changes

  • Update NPM packages
  • Consolidate how we update input fields to prevent double triggering

Testing

Pull the branch down, and play with the input fields.

Review

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4db48fd on over-coa-cap into db5db76 on master.

@higs4281
Copy link
Member

higs4281 commented Aug 8, 2016

👍 going crazy with too much in loans works for me.

@marteki
Copy link
Member Author

marteki commented Aug 8, 2016

Merging.

@marteki marteki merged commit 99709d3 into master Aug 8, 2016
@marteki marteki deleted the over-coa-cap branch August 8, 2016 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants