Fix for Perkins loan caps, unsubsidized graduate loan error message #269
Conversation
…when the user goes over a federal limit in one of the loan fields. The logic was happening too early before - now it will occur when the view updates using the program data, as it should.
|
Does this pull request deal with perkins loans that exceed cost of attendance as well? |
|
@saintsoup52 - Yes |
| @@ -63,7 +63,6 @@ var app = { | |||
| } ); | |||
| } | |||
| // set financial caps based on data | |||
| financialView.setCaps( getFinancial.values() ); | |||
There was a problem hiding this comment.
This line needs to remain in order for the About This Tool page to display loan and grant caps.
There was a problem hiding this comment.
I replaced this, and I'll push a commit up.
|
On focusout, the Grad PLUS loan over cost of attendance error is flashing off screen before it can be read. |
| @@ -351,9 +351,9 @@ | |||
| "resolved": "https://registry.npmjs.org/bluebird/-/bluebird-3.4.1.tgz" | |||
| }, | |||
| "bn.js": { | |||
| "version": "4.11.6", | |||
| "version": "4.11.5", | |||
There was a problem hiding this comment.
In your reducing of merge conflicts, you might have downgraded a lot of dependencies in our shrinkwrapping? I just upgraded a bunch of our NPM packages.
There was a problem hiding this comment.
Oh, I might have. There were conflicts, so I regenerated the file. I don't know why that wouldn't keep the dependency tree...
@marteki - Was this previously addressed? It's possible a merge messed it up. |
|
Focusout: Yeah. I just had a PR merged today to address it. 😞 #267 |
…when the user focusouts from the relevant input.
|
@marteki - The latest commit should fix your error messages not-appearing bug. 😄 |
|
It does! 🙌 👍 |
|
👍 perkins caps show correctly for grad and undergrad perkins schools.
Working for me:
|
…eived on the 'About this page' page.
|
A commit was also pushed to patch a bug in "About this page" |
This PR implements two fixes:
student-debt-calcv2.5.11, which fixes errors with Perkins Loan caps.Changes
student-debt-calcv2.5.11financialView.updateViewWithProgram()which is much better timingTesting
Review
npm install,gulp, and have a good time!Checklist
Animated GIF
When I notice how poorly I coded something in the recent past: