refactor util/TreeNode #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
issue/275/refactor-util-treenode
branch
6 times, most recently
from
9cf4cec to
798e287
Compare
This change uses the results of serialize-and-deserialize-binary-tree-test.cpp to serialize and deserialize trees in O(N) time and O(N) space rather than O(N^2) time and O(N^2) space. TreeNode_cleanup() is a no-op at the moment because it causes a number of double free errors. I think I solved this previously be caching all of the allocated TreeNode instances in a set and only calling delete when the instance was still in the set. Fixes #275 Signed-off-by: Christopher Friedt <chrisfriedt@gmail.com>
cfriedt
force-pushed
the
issue/275/refactor-util-treenode
branch
from
798e287 to
53dc049
Compare
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
==========================================
+ Coverage 97.42% 97.47% +0.05%
==========================================
Files 110 111 +1
Lines 2796 2857 +61
==========================================
+ Hits 2724 2785 +61
Misses 72 72
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses the results of serialize-and-deserialize-binary-tree-test.cpp
to serialize and deserialize trees in O(N) time and O(N) space rather than
O(N^2) time and O(N^2) space.
Fixes #275