Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic version code/name #57

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Conversation

bekuno
Copy link
Member

@bekuno bekuno commented Mar 4, 2020

Fix #43

code is completly reused from cgeo

Fix #43

code is completly reused from cgeo
@kumy
Copy link
Member

kumy commented Mar 4, 2020

Does it change the generated apk filenames? If yes, Jenkins jobs need to been modified ;)

@bekuno
Copy link
Member Author

bekuno commented Mar 4, 2020

@kumy No, only the versionCode and versionName within build.gradle.

@bekuno
Copy link
Member Author

bekuno commented Mar 4, 2020

After PR:

aapt dump badging whereyougo-PR57-2020.03.04-6db1b51-debug.apk
package: name='menion.android.whereyougo' versionCode='20200304' versionName='2020.03.04-d66a51b developer build' compileSdkVersion='28' compileSdkVersionCodename='9'
...

@Lineflyer
Copy link
Member

Great, lets test that.

@Lineflyer Lineflyer merged commit 9c329ca into cgeo:master Mar 4, 2020
@bekuno bekuno deleted the dymanic_version_code branch March 4, 2020 21:14
@bekuno bekuno changed the title dymanic version code/name dynamic version code/name Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve version codes
3 participants