Make Property... (PropertyString etc.) to templates #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove |
…e (still todo)" This reverts commit 5a998f6.
…ilePath, and PropertyString.
|
Reverted commit 5a998f6 and removed REFLECTIONZEUG_API from PropertyFilePath, PropertyColor, PropertyString, and PropertyBool. Compiles on Ubuntu 14.04 with gcc 4.8. |
|
Now we have two reverts of this commit. One in master and another in this branch... can you merge the libzeug master just to make sure nothing confusing happens? |
|
Done. |
cgcostume
added a commit
that referenced
this pull request
Sep 7, 2015
Make Property... (PropertyString etc.) to templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This equalizes the implementation of supported Property types, and makes PropertyString, PropertyBool, PropertyColor, PropertyFilePath, to template classes.
This also adds std::string as datatype for Property instanciation testing.