Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update MODULE.bazel to use go_default_sdk #250

Merged
merged 4 commits into from
Mar 10, 2023
Merged

fix: update MODULE.bazel to use go_default_sdk #250

merged 4 commits into from
Mar 10, 2023

Conversation

cgrindel
Copy link
Owner

Alias the go_default_sdk to be go_sdk so that we can support with and without bzlmod enabled.

Closes #248.

@cgrindel cgrindel self-assigned this Mar 10, 2023
@cgrindel
Copy link
Owner Author

@fmeum Does this change to use go_default_sdk look right to you?

@cgrindel
Copy link
Owner Author

@fmeum I am seeing this error with the change:

go: go.mod file indicates go 1.19, but maximum version supported by tidy is 1.18

Why do we get a different Go SDK when we use go_sdk loading from WORKSPACE vs go_default_sdk when loading from bzlmod?

@fmeum
Copy link

fmeum commented Mar 10, 2023

@cgrindel Sorry, that's on me, I forgot to update the version in the MODULE.bazel file before the release. I'll try to get a new release out with @rules_go//go and Go SDK 1.19.7 in WORKSPACE and MODULE.bazel early next week to unlock you.

@cgrindel
Copy link
Owner Author

@fmeum No sweat. I'll just downgrade my go.mod for now. Thanks.

@fmeum
Copy link

fmeum commented Mar 10, 2023

Thinking about it again, rules_go in the WORKSPACE setup will always fetch the latest version, which may not be ideal for compatibility. I would prefer to keep the auto-registered toolchain version at the highest patch version of the lowest supported minor version.

@cgrindel Would that work for you?

@cgrindel
Copy link
Owner Author

@fmeum I think that is fine. I mostly mentioned the discrepancy because it seemed inconsistent. I don't really care which version of Go I am using in this repo.

@cgrindel cgrindel merged commit 888a680 into main Mar 10, 2023
@cgrindel cgrindel deleted the gh248_fix_go_sdk_ref_new branch March 10, 2023 20:29
renovate bot referenced this pull request in cgrindel/rules_swift_package_manager Mar 11, 2023
@renovate
chore(deps): update dependency cgrindel_bazel_starlib to v0.14.7 (#272)
4ea70de 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [cgrindel_bazel_starlib](https://togithub.com/cgrindel/bazel-starlib)
| http_archive | patch | `v0.14.3` -> `v0.14.7` |

---

### Release Notes

<details>
<summary>cgrindel/bazel-starlib</summary>

###
[`v0.14.7`](https://togithub.com/cgrindel/bazel-starlib/releases/tag/v0.14.7)

[Compare
Source](https://togithub.com/cgrindel/bazel-starlib/compare/v0.14.6...v0.14.7)

#### What's Changed

- Update README.md for v0.14.6 by
[@&#8203;cgrindel-app-token-generator](https://togithub.com/cgrindel-app-token-generator)
in
[https://github.com/cgrindel/bazel-starlib/pull/253](https://togithub.com/cgrindel/bazel-starlib/pull/253)
- chore: more debug for buildifier.sh by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/cgrindel/bazel-starlib/pull/254](https://togithub.com/cgrindel/bazel-starlib/pull/254)

**Full Changelog**:
cgrindel/bazel-starlib@v0.14.6...v0.14.7

#### Workspace Snippet

```python
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "cgrindel_bazel_starlib",
    sha256 = "eaee02fa26e0114b244a30cffac6bb7ee55162bd347e8ab4d22dee42cee88ac5",
    urls = [
        "https://github.com/cgrindel/bazel-starlib/releases/download/v0.14.7/bazel-starlib.v0.14.7.tar.gz",
    ],
)

load("@&#8203;cgrindel_bazel_starlib//:deps.bzl", "bazel_starlib_dependencies")

bazel_starlib_dependencies()

load("@&#8203;bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")

bazel_skylib_workspace()
```

###
[`v0.14.6`](https://togithub.com/cgrindel/bazel-starlib/releases/tag/v0.14.6)

[Compare
Source](https://togithub.com/cgrindel/bazel-starlib/compare/v0.14.5...v0.14.6)

#### What's Changed

- Update README.md for v0.14.5 by
[@&#8203;cgrindel-app-token-generator](https://togithub.com/cgrindel-app-token-generator)
in
[https://github.com/cgrindel/bazel-starlib/pull/251](https://togithub.com/cgrindel/bazel-starlib/pull/251)
- chore: add more debug code to `buildifier.sh` by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/cgrindel/bazel-starlib/pull/252](https://togithub.com/cgrindel/bazel-starlib/pull/252)

**Full Changelog**:
cgrindel/bazel-starlib@v0.14.5...v0.14.6

#### Workspace Snippet

```python
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "cgrindel_bazel_starlib",
    sha256 = "be0c678818ad9b1f31ad8827c247bcd59135793e053a5fec0f0c08371a97e0da",
    urls = [
        "https://github.com/cgrindel/bazel-starlib/releases/download/v0.14.6/bazel-starlib.v0.14.6.tar.gz",
    ],
)

load("@&#8203;cgrindel_bazel_starlib//:deps.bzl", "bazel_starlib_dependencies")

bazel_starlib_dependencies()

load("@&#8203;bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")

bazel_skylib_workspace()
```

###
[`v0.14.5`](https://togithub.com/cgrindel/bazel-starlib/releases/tag/v0.14.5)

[Compare
Source](https://togithub.com/cgrindel/bazel-starlib/compare/v0.14.4...v0.14.5)

#### What's Changed

- fix: switch to runfiles.bash v3 by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/cgrindel/bazel-starlib/pull/249](https://togithub.com/cgrindel/bazel-starlib/pull/249)
- fix: update `MODULE.bazel` to use `go_default_sdk` by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/cgrindel/bazel-starlib/pull/250](https://togithub.com/cgrindel/bazel-starlib/pull/250)

**Full Changelog**:
cgrindel/bazel-starlib@v0.14.4...v0.14.5

#### Workspace Snippet

```python
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "cgrindel_bazel_starlib",
    sha256 = "db89cac4a8d6c0e39589304db0dc1c97c083f6f2a122089aceb3d8efc1511a95",
    urls = [
        "https://github.com/cgrindel/bazel-starlib/releases/download/v0.14.5/bazel-starlib.v0.14.5.tar.gz",
    ],
)

load("@&#8203;cgrindel_bazel_starlib//:deps.bzl", "bazel_starlib_dependencies")

bazel_starlib_dependencies()

load("@&#8203;bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")

bazel_skylib_workspace()
```

###
[`v0.14.4`](https://togithub.com/cgrindel/bazel-starlib/releases/tag/v0.14.4)

[Compare
Source](https://togithub.com/cgrindel/bazel-starlib/compare/v0.14.3...v0.14.4)

#### What's Changed

- Update README.md for v0.14.3 by
[@&#8203;cgrindel-app-token-generator](https://togithub.com/cgrindel-app-token-generator)
in
[https://github.com/cgrindel/bazel-starlib/pull/245](https://togithub.com/cgrindel/bazel-starlib/pull/245)
- chore: add debug code to `buildifier.sh` by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/cgrindel/bazel-starlib/pull/246](https://togithub.com/cgrindel/bazel-starlib/pull/246)

**Full Changelog**:
cgrindel/bazel-starlib@v0.14.3...v0.14.4

#### Workspace Snippet

```python
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "cgrindel_bazel_starlib",
    sha256 = "78e8754ce435bc2292d9157682fd842335239fe664cb4f75fed5968203c70794",
    urls = [
        "https://github.com/cgrindel/bazel-starlib/releases/download/v0.14.4/bazel-starlib.v0.14.4.tar.gz",
    ],
)

load("@&#8203;cgrindel_bazel_starlib//:deps.bzl", "bazel_starlib_dependencies")

bazel_starlib_dependencies()

load("@&#8203;bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")

bazel_skylib_workspace()
```

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/cgrindel/swift_bazel).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNjAuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE2MC4wIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot referenced this pull request in cgrindel/github_snippets Mar 11, 2023
@renovate
chore(deps): update dependency cgrindel_bazel_starlib to v0.14.7 (#28)
c001d43 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [cgrindel_bazel_starlib](https://togithub.com/cgrindel/bazel-starlib)
| http_archive | patch | `v0.14.4` -> `v0.14.7` |

---

### Release Notes

<details>
<summary>cgrindel/bazel-starlib</summary>

###
[`v0.14.7`](https://togithub.com/cgrindel/bazel-starlib/releases/tag/v0.14.7)

[Compare
Source](https://togithub.com/cgrindel/bazel-starlib/compare/v0.14.6...v0.14.7)

#### What's Changed

- Update README.md for v0.14.6 by
[@&#8203;cgrindel-app-token-generator](https://togithub.com/cgrindel-app-token-generator)
in
[https://github.com/cgrindel/bazel-starlib/pull/253](https://togithub.com/cgrindel/bazel-starlib/pull/253)
- chore: more debug for buildifier.sh by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/cgrindel/bazel-starlib/pull/254](https://togithub.com/cgrindel/bazel-starlib/pull/254)

**Full Changelog**:
cgrindel/bazel-starlib@v0.14.6...v0.14.7

#### Workspace Snippet

```python
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "cgrindel_bazel_starlib",
    sha256 = "eaee02fa26e0114b244a30cffac6bb7ee55162bd347e8ab4d22dee42cee88ac5",
    urls = [
        "https://github.com/cgrindel/bazel-starlib/releases/download/v0.14.7/bazel-starlib.v0.14.7.tar.gz",
    ],
)

load("@&#8203;cgrindel_bazel_starlib//:deps.bzl", "bazel_starlib_dependencies")

bazel_starlib_dependencies()

load("@&#8203;bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")

bazel_skylib_workspace()
```

###
[`v0.14.6`](https://togithub.com/cgrindel/bazel-starlib/releases/tag/v0.14.6)

[Compare
Source](https://togithub.com/cgrindel/bazel-starlib/compare/v0.14.5...v0.14.6)

#### What's Changed

- Update README.md for v0.14.5 by
[@&#8203;cgrindel-app-token-generator](https://togithub.com/cgrindel-app-token-generator)
in
[https://github.com/cgrindel/bazel-starlib/pull/251](https://togithub.com/cgrindel/bazel-starlib/pull/251)
- chore: add more debug code to `buildifier.sh` by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/cgrindel/bazel-starlib/pull/252](https://togithub.com/cgrindel/bazel-starlib/pull/252)

**Full Changelog**:
cgrindel/bazel-starlib@v0.14.5...v0.14.6

#### Workspace Snippet

```python
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "cgrindel_bazel_starlib",
    sha256 = "be0c678818ad9b1f31ad8827c247bcd59135793e053a5fec0f0c08371a97e0da",
    urls = [
        "https://github.com/cgrindel/bazel-starlib/releases/download/v0.14.6/bazel-starlib.v0.14.6.tar.gz",
    ],
)

load("@&#8203;cgrindel_bazel_starlib//:deps.bzl", "bazel_starlib_dependencies")

bazel_starlib_dependencies()

load("@&#8203;bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")

bazel_skylib_workspace()
```

###
[`v0.14.5`](https://togithub.com/cgrindel/bazel-starlib/releases/tag/v0.14.5)

[Compare
Source](https://togithub.com/cgrindel/bazel-starlib/compare/v0.14.4...v0.14.5)

#### What's Changed

- fix: switch to runfiles.bash v3 by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/cgrindel/bazel-starlib/pull/249](https://togithub.com/cgrindel/bazel-starlib/pull/249)
- fix: update `MODULE.bazel` to use `go_default_sdk` by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/cgrindel/bazel-starlib/pull/250](https://togithub.com/cgrindel/bazel-starlib/pull/250)

**Full Changelog**:
cgrindel/bazel-starlib@v0.14.4...v0.14.5

#### Workspace Snippet

```python
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "cgrindel_bazel_starlib",
    sha256 = "db89cac4a8d6c0e39589304db0dc1c97c083f6f2a122089aceb3d8efc1511a95",
    urls = [
        "https://github.com/cgrindel/bazel-starlib/releases/download/v0.14.5/bazel-starlib.v0.14.5.tar.gz",
    ],
)

load("@&#8203;cgrindel_bazel_starlib//:deps.bzl", "bazel_starlib_dependencies")

bazel_starlib_dependencies()

load("@&#8203;bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")

bazel_skylib_workspace()
```

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/cgrindel/github_snippets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNjAuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE2MC4wIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cgrindel cgrindel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the Go SDK reference in MODULE.bazel
2 participants
@cgrindel @fmeum