Merge pull request #1496 from NicoPennec/fix/various

Various fixes

package.json

@@ -24,14 +24,14 @@
     "@fullcalendar/multimonth": "6.1.15",
     "@fullcalendar/vue": "6.1.15",
     "@google/model-viewer": "3.5.0",
-    "@sentry/vue": "8.18.0",
+    "@sentry/vue": "8.19.0",
     "async": "3.2.5",
     "bowser": "2.11.0",
     "chart.js": "2.9.4",
     "color-hash": "2.0.2",
     "color-string": "1.9.1",
     "fabric": "cgwire/fabric.js",
-    "lucide-vue": "0.408.0",
+    "lucide-vue": "0.414.0",
     "marked": "13.0.2",
     "marked-emoji": "1.4.1",
     "moment": "2.30.1",
@@ -65,7 +65,6 @@
     "wavesurfer.js": "7.8.2"
   },
   "devDependencies": {
-    "@types/vue-feather-icons": "5.0.8",
     "@vitejs/plugin-vue2": "2.3.1",
     "@vue/compiler-sfc": "2.7.16",
     "@vue/test-utils": "1.3.6",
@@ -76,7 +75,7 @@
     "eslint-plugin-vue": "9.27.0",
     "esm": "3.2.25",
     "husky": "8.0.3",
-    "jsdom": "24.1.0",
+    "jsdom": "24.1.1",
     "lint-staged": "15.2.7",
     "localStorage": "1.0.4",
     "prettier": "3.3.3",

src/App.vue

@@ -11,7 +11,8 @@
     <router-view v-else />
 
     <preview-modal
-      :active="previewFileIdToShow.length > 0"
+      v-if="previewFileIdToShow"
+      active
       :preview-file-id="previewFileIdToShow"
       @cancel="() => $store.commit('HIDE_PREVIEW_FILE')"
     />
@@ -701,10 +702,6 @@ body {
   }
 } // End dark theme
 
-#app .router-link-active {
-  color: #00d1b2;
-}
-
 .loading-info {
   background: white;
 }

src/components/lists/TimeSpentTaskList.vue

@@ -1,6 +1,6 @@
 <template>
   <div class="data-list">
-    <table-info :is-loading="isLoading" :is-error="isLoadingError" />
+    <table-info :is-loading="isLoading" :is-error="isError" />
 
     <div class="aggregated-time-spents">
       <div
@@ -82,7 +82,7 @@ export default {
       type: Boolean,
       default: false
     },
-    isLoadingError: {
+    isError: {
       type: Boolean,
       default: false
     }

src/components/modals/base_modal.js

@@ -22,14 +22,16 @@ export const modalMixin = {
 
   watch: {
     /*
-     * Make sure that the keydown event is removed each time, the modla is
-     * hidden.
+     * Make sure that the keydown event is removed each time the modal is hidden.
      */
-    active() {
-      if (this.active) {
-        window.addEventListener('keydown', this.onKeyDown, false)
-      } else {
-        window.removeEventListener('keydown', this.onKeyDown)
+    active: {
+      immediate: true,
+      handler() {
+        if (this.active) {
+          window.addEventListener('keydown', this.onKeyDown, false)
+        } else {
+          window.removeEventListener('keydown', this.onKeyDown)
+        }
       }
     }
   }

src/components/pages/Assets.vue

@@ -23,7 +23,7 @@
               <combobox-department
                 class="combobox-department flexrow-item"
                 :selectable-departments="selectableDepartments('Asset')"
-                :dispay-all-and-my-departments="true"
+                :display-all-and-my-departments="true"
                 rounded
                 v-model="selectedDepartment"
                 v-if="departments.length > 0"