Bug: Inherited status / statusCode properties can not be checked

[austince]

Using the popular error library http-errors, the normal chai-http assertions for status / statusCode do not work. I think this is because of the inheritence used by http-errors when creating new error objects.

I have this, which works:

const createError = require('http-errors');

  try {
    throw createError(400, "Bad request");
  } catch (err) {
    expect(err).to.have.property('message');
    expect(err).to.have.property('status');
    expect(err.status).to.equal(400);
    return;
  }

It should probably still work as:

const createError = require('http-errors');

  try {
    throw createError(400, "Bad request");
  } catch (err) {
    expect(err).to.have.property('message');
    expect(err).to.have.status(400);
    return;
  }

[keithamus]

Hey @austince thanks for the issue!

I'm guessing this doesn't work because of L80 in the status assertion:

chai-http/lib/http.js

Lines 79 to 90 in 1af976d

	Assertion.addMethod('status', function (code) {
	new Assertion(this._obj).to.have.any.keys('status', 'statusCode');
	var status = this._obj.status || this._obj.statusCode;
	this.assert(
	status == code
	, 'expected #{this} to have status code #{exp} but got #{act}'
	, 'expected #{this} to not have status code #{act}'
	, code
	, status
	);
	});

We should make this work though! We could change that assertion to just use something like if('status' in this._obj) instead.

PR's welcome!

[austince]

Fixed with #219 🎊